Update HTML4::DocumentFragment#initialize & #parse to take kwargs #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattJones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#3323
Have you included adequate test coverage?
Yes and No. Test coverage is included for
#parse. But the theDocumentFragment.newclass method calls a C method, which is not getting touched here. Thus I can't add in tests using.new.@flavorjones : you'll need to update the C code to accept keyword args. Then, you can update this call. Also you'll want to add some tests. I added two in
test_document_fragmentbefore I realized they wouldn't work. One for "without a context node" and one for "with a context node".Does this change affect the behavior of either the C or the Java implementations?
I.... don't think so?