Mermaid rendering support? #7
mallardduck
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
This is Spatie, we don't do Let's go for option 1. If the code is too complex for us to maintain (we only take on simple things), you could probably use some of the work for option 2. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With GitHub's addition of mermaid chart rendering in Markdown I'm wondering about adding similar functionality to Commonmark PHP projects. However I don't really want to loose access to Shiki highlighting to gain Mermaid charts.
Ideally it'd be great to be able to have access to both Shiki highlighting in commonmark and mermaid charts. However I think to accomplish this we'd need to have a custom
FencedCodeRenderer
andIndentedCodeRenderer
which renders via mermaid charts if the code blocks language is set tomermaid
.To accomplish this I could either see:
*Renderer
classes extensible (so consumers of this plugin can monkey patch support for other render workflows.In any case, I figured it'd be good to start a chat about the idea here first.
As long as this library doesn't plan to make classes to
final
then I could probably do option 2 myself by making a new package. Otherwise, options 1 and 3 are ones I'd be willing to work on Pull Requests for. Would just like to discuss which option is preferred before working on it.Beta Was this translation helpful? Give feedback.
All reactions