Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations of implemented interfaces since PHP 8.1 for CrawlObserverCollection class #395

Closed
Rezyan opened this issue Mar 19, 2022 · 0 comments

Comments

@Rezyan
Copy link
Contributor

Rezyan commented Mar 19, 2022

Hi,

This issue is related to this one from the spatie/laravel-sitemap repository. Since the PHP 8.1 version, the CrawlObserverCollection class emits deprecations due to the implemented interfaces.

PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 66
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 52
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 57
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 71
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 47
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 76
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 81
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 86
PHP Deprecated:  Return type of Spatie\Crawler\CrawlObservers\CrawlObserverCollection::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/spatie/crawler/src/CrawlObservers/CrawlObserverCollection.php on line 91

Regards.

@Rezyan Rezyan changed the title Deprecations of implemented interfaces since **PHP 8.1** for CrawlObserverCollection class Deprecations of implemented interfaces since PHP 8.1 for CrawlObserverCollection class Mar 19, 2022
@Rezyan Rezyan mentioned this issue Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant