Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading documentation for Media::setNewOrder method #3758

Closed
rottifant opened this issue Jan 2, 2025 · 0 comments · Fixed by #3759
Closed

Misleading documentation for Media::setNewOrder method #3758

rottifant opened this issue Jan 2, 2025 · 0 comments · Fixed by #3759

Comments

@rottifant
Copy link
Contributor

The documentation states:

“the record with the first id in the array will get order 11, the record with the second id will get order 2, …”

This is incorrect and confusing.
The actual behavior, as per the code, assigns the first record the startOrder (default is 1), the second record gets startOrder + 1, and so on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix confusing documentation for Media::setNewOrder method rottifant/laravel-medialibrary
1 participant
@rottifant