Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous syntax in License Match Template for match and original keywords with double quotes #497

Closed
goneall opened this issue Mar 7, 2021 · 2 comments

Comments

@goneall
Copy link
Member

goneall commented Mar 7, 2021

Double quotes are used to delimit keywords in the License Templates. If one of the keyword values contains a double quote, the processing is not specified leading to inconsistencies and errors.

For example, if you want to include parenthesis in the match= you would have match="this is "quote""

This situation has occurred for the original text keyword (see issue spdx/license-list-XML#1104 for details).

@goneall
Copy link
Member Author

goneall commented Mar 7, 2021

One possible solution is to move to the License XML format and deprecate the template text format.

The License XML contains significantly more semantic information on the license content which may be valuable to downstream consumers.

This solution would require fully specifying the XML format in the SPDX specification.

@goneall
Copy link
Member Author

goneall commented Mar 7, 2021

This turned out not to be the issue - the issue was with the semi-colon.

Closing this out,

@goneall goneall closed this as completed Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant