Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated property in response.js (+ easy fix) #382

Open
franz-josef-kaiser opened this issue Mar 22, 2021 · 2 comments
Open

Deprecated property in response.js (+ easy fix) #382

franz-josef-kaiser opened this issue Mar 22, 2021 · 2 comments

Comments

@franz-josef-kaiser
Copy link

franz-josef-kaiser commented Mar 22, 2021

Node version 12 depracated OutgoingMessage.prototype._headers, which is used here in response.js L#18.

The fix is easy: Use getHeaders() instead:

  this.statusCode = statusCode

-   if (this._headers) {
+   if (this.getHeaders()) {
    // Slow-case: when progressive API and header fields are passed.
    if (obj) {

You can inspect the full trace when running node with --trace-deprecation flag.

@franz-josef-kaiser franz-josef-kaiser changed the title Deprecated property in response Deprecated property in response.js (+ easy fix) Mar 22, 2021
@axelrindle
Copy link

There is already a PR for it, see #367. But there has been no activity for half a year now...

@khteh
Copy link

khteh commented Aug 22, 2022

It's been more than a year now. No fix!?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants