Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler does not obey Stream.push api #60

Open
jacobheun opened this issue Nov 5, 2018 · 0 comments
Open

Scheduler does not obey Stream.push api #60

jacobheun opened this issue Nov 5, 2018 · 0 comments

Comments

@jacobheun
Copy link
Contributor

Currently when the Scheduler ticks it will run through all chunks for all scheduled items and push the chunks onto the stream. The resulting Boolean from push is not checked for every chunk, which can result in an error if pushes become disallowed during the tick.

The problem lines are
https://github.com/spdy-http2/spdy-transport/blob/v2.1.1/lib/spdy-transport/protocol/base/scheduler.js#L124
and
https://github.com/spdy-http2/spdy-transport/blob/v2.1.1/lib/spdy-transport/protocol/base/scheduler.js#L164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant