Upgrade insecure dependency PyYAML to 4.2b2+ #897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamyohann
changed the title
|
Hey @iamyohann , Have a read through this thread: python-openapi/openapi-spec-validator#60 TL;DR - We can't pin a beta release, as it will break dependency managers like pipenv. However, this CVE only relates to the use of yaml.load(), which we do not use (we use safe_load, or extend the safe loader). |
|
@dtkav I see, can I leave this PR open until a stable version of PyYAML is released? |
|
Yeah, absolutely.
…On Wed, Mar 6, 2019 at 1:47 PM Yohann ***@***.***> wrote:
@dtkav <https://github.com/dtkav> I see, can I leave this PR open until a
stable version of PyYAML is released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#897 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAlPSQDhRDpLsocMtAScvZBx4ssO0V8Eks5vTzM8gaJpZM4bfy3s>
.
|
|
So with 5.1 it should be fine unless there are also side effects as in yaml/pyyaml#265? |
|
superseded by #902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: