-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[META] Support ES Modules #1640
Comments
A downside is more round trips for the first visit, which is probably okay. |
Yeah, I think that's fine. We can measure the difference too. |
Firefox 60 has landed 🎉 Edit: An interesting support indicator https://aremodulesready.com/ |
It seems MSEdge on April 2018 update does not support dynamic import() yet. (Still disabled by default) |
@marcoscaceres You recently said you are planning to use Webpack/Rollup. Do we still ultimately want to do ES modules then? |
I think ultimately, yes. But we need to trial it to see if they are fast enough (I think they will be... but we need to do some tests). We are still waiting on |
Closing, as I think we will still want to bundle everything for the foreseeable future. We can always look at this again down the road... and, in fact, it kinda already works... we just don't deploy ReSpec this way. |
When Firefox 60 lands in May, we will have ES module support across all target browsers. That means we can start considering using them in ReSpec.
We should evaluate what that means for our current plugin design and for the dependencies (which are not ES Modules). With dynamic
import()
support, we can basically get rid of RequireJS.Ideally, we would then have ReSpec do this:
Just some lose thoughts for now... but it's exciting because potentially this will make ReSpec super tiny, with each spec only loading just what it needs. Right now, we load everything, and that's super wasteful. The modules can be cached, and shared across specs... that may lead to interesting versioning issues, but we can deal with that.
Thoughts?
The text was updated successfully, but these errors were encountered: