From de7e180080fcc3bc99d694f50b9123f70ab8f0a2 Mon Sep 17 00:00:00 2001
From: Connor Ivy <connor@speckle.systems>
Date: Tue, 16 Jul 2024 17:29:54 -0500
Subject: [PATCH 1/4] add curve to direct shape conversions

---
 .../Speckle.Converters.RevitShared.projitems  |  8 +++
 .../ArcToDirectShapeConverterToHost.cs        | 17 +++++++
 .../CircleToDirectShapeConverterToHost.cs     | 17 +++++++
 .../CurveToDirectShapeConverterToHost.cs      | 17 +++++++
 .../EllipseToDirectShapeConverterToHost.cs    | 17 +++++++
 .../ICurveToDirectShapeConverterToHostBase.cs | 50 +++++++++++++++++++
 .../LineToDirectShapeConverterToHost.cs       | 17 +++++++
 .../ToDirectShape/PolycurveConverterToHost.cs | 17 +++++++
 .../ToDirectShape/PolylineConverterToHost.cs  | 17 +++++++
 9 files changed, 177 insertions(+)
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs
 create mode 100644 Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs

diff --git a/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems b/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems
index 814e6fee3..41f4e2f28 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems
+++ b/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems
@@ -37,12 +37,20 @@
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\PlaneConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\PointConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\PolylineConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\ArcToDirectShapeConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\CircleToDirectShapeConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\CurveToDirectShapeConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\EllipseToDirectShapeConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\LineToDirectShapeConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\PolycurveConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\PolylineConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\VectorConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\RenderMaterialToHostConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\SurfaceConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\BaseTopLevelConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\BrepToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\DirectShapeTopLevelConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\ICurveToDirectShapeConverterToHostBase.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\LevelToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\GridlineToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\MeshToHostTopLevelConverter.cs" />
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs
new file mode 100644
index 000000000..58530a607
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Arc), 0)]
+public class ArcToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Arc>
+{
+  public ArcToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs
new file mode 100644
index 000000000..c8a731d3f
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Circle), 0)]
+public class CircleToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Circle>
+{
+  public CircleToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs
new file mode 100644
index 000000000..3f7482eed
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Curve), 0)]
+public class CurveToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Curve>
+{
+  public CurveToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs
new file mode 100644
index 000000000..a21da783b
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Ellipse), 0)]
+public class EllipseToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Ellipse>
+{
+  public EllipseToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs
new file mode 100644
index 000000000..1bf73a661
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs
@@ -0,0 +1,50 @@
+using Objects;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Core.Models;
+
+namespace Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+public abstract class ICurveToDirectShapeConverterToHostBase<TCurve>
+  : ITypedConverter<TCurve, List<DB.GeometryObject>>,
+    IToHostTopLevelConverter
+  where TCurve : Base, ICurve
+{
+  private readonly IRevitConversionContextStack _contextStack;
+  private readonly ITypedConverter<ICurve, DB.CurveArray> _curveConverter;
+
+  public ICurveToDirectShapeConverterToHostBase(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+  {
+    _contextStack = contextStack;
+    _curveConverter = curveConverter;
+  }
+
+  public List<DB.GeometryObject> Convert(TCurve target)
+  {
+    var converted = new List<DB.GeometryObject>();
+
+    DB.CurveArray curveArray = _curveConverter.Convert(target);
+    converted.AddRange(curveArray.Cast<DB.Curve>());
+
+    var genericModelCategory = _contextStack.Current.Document.Settings.Categories.get_Item(
+      DB.BuiltInCategory.OST_GenericModel
+    );
+
+    var revitDs = DB.DirectShape.CreateElement(_contextStack.Current.Document, genericModelCategory.Id);
+    if (target is Base speckleObject && speckleObject.applicationId != null)
+    {
+      revitDs.ApplicationId = speckleObject.applicationId;
+    }
+
+    revitDs.ApplicationDataId = Guid.NewGuid().ToString();
+    revitDs.SetShape(converted);
+    revitDs.Name = "CurveAsDirectShape";
+
+    return converted;
+  }
+
+  public object Convert(Base target) => Convert((TCurve)target);
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs
new file mode 100644
index 000000000..85a989ba8
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Line), 0)]
+public class LineToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Line>
+{
+  public LineToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs
new file mode 100644
index 000000000..0056fe612
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Polycurve), 0)]
+public class PolycurveToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Polycurve>
+{
+  public PolycurveToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs
new file mode 100644
index 000000000..e02a848aa
--- /dev/null
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs
@@ -0,0 +1,17 @@
+using Objects;
+using Speckle.Converters.Common;
+using Speckle.Converters.Common.Objects;
+using Speckle.Converters.RevitShared.Helpers;
+using Speckle.Converters.RevitShared.ToHost.TopLevel;
+
+namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
+
+[NameAndRankValue(nameof(SOG.Polyline), 0)]
+public class PolylineToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Polyline>
+{
+  public PolylineToDirectShapeConverterToHost(
+    IRevitConversionContextStack contextStack,
+    ITypedConverter<ICurve, DB.CurveArray> curveConverter
+  )
+    : base(contextStack, curveConverter) { }
+}

From 740c388d79f6cf66fb7fa71fda5377153f18d040 Mon Sep 17 00:00:00 2001
From: Connor Ivy <connor@speckle.systems>
Date: Wed, 17 Jul 2024 16:39:58 -0500
Subject: [PATCH 2/4] rename base converter

---
 .../TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs | 2 +-
 .../ToDirectShape/CircleToDirectShapeConverterToHost.cs       | 2 +-
 .../ToDirectShape/CurveToDirectShapeConverterToHost.cs        | 2 +-
 ...ToHostBase.cs => CurveToDirectShapeConverterToHostBase.cs} | 4 ++--
 .../ToDirectShape/EllipseToDirectShapeConverterToHost.cs      | 2 +-
 .../ToDirectShape/LineToDirectShapeConverterToHost.cs         | 2 +-
 .../ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs | 2 +-
 .../ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs  | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)
 rename Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/{ICurveToDirectShapeConverterToHostBase.cs => CurveToDirectShapeConverterToHostBase.cs} (92%)

diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs
index 58530a607..aaf05f8e7 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ArcToDirectShapeConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Arc), 0)]
-public class ArcToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Arc>
+public class ArcToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Arc>
 {
   public ArcToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs
index c8a731d3f..5655d5e59 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CircleToDirectShapeConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Circle), 0)]
-public class CircleToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Circle>
+public class CircleToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Circle>
 {
   public CircleToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs
index 3f7482eed..de794fbc9 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Curve), 0)]
-public class CurveToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Curve>
+public class CurveToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Curve>
 {
   public CurveToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHostBase.cs
similarity index 92%
rename from Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs
rename to Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHostBase.cs
index 1bf73a661..a4f74f7ee 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/CurveToDirectShapeConverterToHostBase.cs
@@ -5,7 +5,7 @@
 
 namespace Speckle.Converters.RevitShared.ToHost.TopLevel;
 
-public abstract class ICurveToDirectShapeConverterToHostBase<TCurve>
+public abstract class CurveToDirectShapeConverterToHostBase<TCurve>
   : ITypedConverter<TCurve, List<DB.GeometryObject>>,
     IToHostTopLevelConverter
   where TCurve : Base, ICurve
@@ -13,7 +13,7 @@ public abstract class ICurveToDirectShapeConverterToHostBase<TCurve>
   private readonly IRevitConversionContextStack _contextStack;
   private readonly ITypedConverter<ICurve, DB.CurveArray> _curveConverter;
 
-  public ICurveToDirectShapeConverterToHostBase(
+  public CurveToDirectShapeConverterToHostBase(
     IRevitConversionContextStack contextStack,
     ITypedConverter<ICurve, DB.CurveArray> curveConverter
   )
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs
index a21da783b..5f1027a43 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/EllipseToDirectShapeConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Ellipse), 0)]
-public class EllipseToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Ellipse>
+public class EllipseToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Ellipse>
 {
   public EllipseToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs
index 85a989ba8..3c46b86fd 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/LineToDirectShapeConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Line), 0)]
-public class LineToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Line>
+public class LineToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Line>
 {
   public LineToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs
index 0056fe612..f4c914bfd 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolycurveConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Polycurve), 0)]
-public class PolycurveToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Polycurve>
+public class PolycurveToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Polycurve>
 {
   public PolycurveToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,
diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs
index e02a848aa..bdaff8079 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ToDirectShape/PolylineConverterToHost.cs
@@ -7,7 +7,7 @@
 namespace Speckle.Converters.RevitShared.ToHost.Raw.Geometry;
 
 [NameAndRankValue(nameof(SOG.Polyline), 0)]
-public class PolylineToDirectShapeConverterToHost : ICurveToDirectShapeConverterToHostBase<SOG.Polyline>
+public class PolylineToDirectShapeConverterToHost : CurveToDirectShapeConverterToHostBase<SOG.Polyline>
 {
   public PolylineToDirectShapeConverterToHost(
     IRevitConversionContextStack contextStack,

From 29182143a97848c9f5db041ce71091e15693cb64 Mon Sep 17 00:00:00 2001
From: Connor Ivy <connor@speckle.systems>
Date: Thu, 18 Jul 2024 16:46:11 -0500
Subject: [PATCH 3/4] update projitems

---
 .../Speckle.Converters.RevitShared.projitems                    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems b/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems
index 50a1bb547..b1954f59e 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems
+++ b/Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems
@@ -40,6 +40,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\ArcToDirectShapeConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\CircleToDirectShapeConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\CurveToDirectShapeConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\CurveToDirectShapeConverterToHostBase.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\EllipseToDirectShapeConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\LineToDirectShapeConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\PolycurveConverterToHost.cs" />
@@ -50,7 +51,6 @@
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\BaseTopLevelConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\BrepToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\DirectShapeTopLevelConverterToHost.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\ICurveToDirectShapeConverterToHostBase.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\LevelToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\GridlineToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\MeshToHostTopLevelConverter.cs" />

From d2c5fe76e05608c68b59a6d663dcd0179175d7c3 Mon Sep 17 00:00:00 2001
From: Adam Hathcock <adam@speckle.systems>
Date: Fri, 19 Jul 2024 08:01:47 +0100
Subject: [PATCH 4/4] Fix XML comments

---
 .../HostApp/AutocadLayerManager.cs                              | 2 --
 .../Speckle.Connectors.Rhino7/HostApp/RhinoLayerManager.cs      | 1 -
 2 files changed, 3 deletions(-)

diff --git a/Connectors/Autocad/Speckle.Connectors.AutocadShared/HostApp/AutocadLayerManager.cs b/Connectors/Autocad/Speckle.Connectors.AutocadShared/HostApp/AutocadLayerManager.cs
index 73f2f360d..9fc06221e 100644
--- a/Connectors/Autocad/Speckle.Connectors.AutocadShared/HostApp/AutocadLayerManager.cs
+++ b/Connectors/Autocad/Speckle.Connectors.AutocadShared/HostApp/AutocadLayerManager.cs
@@ -27,7 +27,6 @@ public AutocadLayerManager(AutocadContext autocadContext)
   /// Will create a layer with the provided name, or, if it finds an existing one, will "purge" all objects from it.
   /// This ensures we're creating the new objects we've just received rather than overlaying them.
   /// </summary>
-  /// <param name="layerName">Name to search layer for purge and create.</param>
   public void CreateLayerForReceive(Collection layerCollection)
   {
     string layerName = layerCollection.name;
@@ -159,7 +158,6 @@ public void CreateLayerFilter(string projectName, string modelName)
   /// </summary>
   /// <param name="context"></param>
   /// <param name="baseLayerPrefix"></param>
-  /// <param name="color"> Returns the color if found on a collection-based path, or null</param>
   /// <returns></returns>
   public Layer GetLayerPath(TraversalContext context, string baseLayerPrefix)
   {
diff --git a/Connectors/Rhino/Speckle.Connectors.Rhino7/HostApp/RhinoLayerManager.cs b/Connectors/Rhino/Speckle.Connectors.Rhino7/HostApp/RhinoLayerManager.cs
index 3bedf9834..59a820289 100644
--- a/Connectors/Rhino/Speckle.Connectors.Rhino7/HostApp/RhinoLayerManager.cs
+++ b/Connectors/Rhino/Speckle.Connectors.Rhino7/HostApp/RhinoLayerManager.cs
@@ -29,7 +29,6 @@ public void CreateBaseLayer(string baseLayerName)
   /// <summary>
   /// <para>For receive: Use this method to construct layers in the host app when receiving.</para>.
   /// </summary>
-  /// <param name="path"></param>
   /// <param name="baseLayerName"></param>
   /// <returns></returns>
   public int GetAndCreateLayerFromPath(Collection[] collectionPath, string baseLayerName)