Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print the total run time at completion of validation #130

Closed
joshtemple opened this issue Nov 15, 2019 · 0 comments
Closed

Print the total run time at completion of validation #130

joshtemple opened this issue Nov 15, 2019 · 0 comments
Labels
Enhancement New feature or request
Milestone
0.1.1

Comments

@joshtemple
Copy link
Collaborator

Spectacles should time itself and print out the total runtime at the end when running a validator.

An example of this would be:

Completed SQL validation in 38 seconds

As a bonus, elapsed time should be printed in the most human-readable form, e.g. 2 minutes and 47 seconds instead of 167 seconds.
@joshtemple joshtemple added the Enhancement New feature or request label Nov 15, 2019
Hawk94 pushed a commit to Hawk94/spectacles that referenced this issue Nov 16, 2019
Issue spectacles-ci#130: Print the total run time at completion of va…
14df546 
…lidation
@joshtemple joshtemple added this to the 0.1.1 milestone Nov 18, 2019
DylanBaker pushed a commit that referenced this issue Nov 18, 2019
@Hawk94 @DylanBaker
Feature/log time assert (#134)
cbb17ff 
* Issue #130: Print the total run time at completion of validation

* Add newline

* Fixing flake8

* Remove patch from imports

* Reformatting according to black

* Extend log_time decorator to handle other validators

* Rename to log_duration. Move to the validate_ functions to capture the setup of the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
2 participants
@joshtemple @DylanBaker