Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log response from Looker in handle_exceptions #213

Closed
joshtemple opened this issue May 27, 2020 · 0 comments · Fixed by #217
Closed

Log response from Looker in handle_exceptions #213

joshtemple opened this issue May 27, 2020 · 0 comments · Fixed by #217
Assignees
@joshtemple
Labels
Enhancement New feature or request
Milestone
0.2.1

Comments

@joshtemple
Copy link
Collaborator

We should catch and handle LookerApiError specifically here.

The exception object has a response attribute which is the raw response from Looker. We can log (at a debug level) the response which will help a lot with debugging (even though, sometimes the message from Looker is not useful).
@joshtemple joshtemple added the Enhancement New feature or request label May 27, 2020
@joshtemple joshtemple added this to the 0.2.1 milestone Jun 3, 2020
@joshtemple joshtemple self-assigned this Jun 3, 2020
@joshtemple joshtemple mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshtemple joshtemple

Labels
Enhancement New feature or request
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Specifically handle Looker API errors spectacles-ci/spectacles
1 participant
@joshtemple