Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid mode only returns explore level errors #215

Closed
DylanBaker opened this issue Jun 3, 2020 · 0 comments · Fixed by #216
Closed

Hybrid mode only returns explore level errors #215

DylanBaker opened this issue Jun 3, 2020 · 0 comments · Fixed by #216
Assignees
@joshtemple
Labels
Bug Something isn't working
Milestone
0.2.1

Comments

@DylanBaker
Copy link
Collaborator

In hybrid mode, an explore has an error set and as a result this following code never gets to creating errors for dimensions: https://github.com/spectacles-ci/spectacles/blob/master/spectacles/lookml.py#L266-L272
@joshtemple joshtemple added this to the 0.2.1 milestone Jun 3, 2020
@joshtemple joshtemple added the Bug Something isn't working label Jun 3, 2020
@joshtemple joshtemple self-assigned this Jun 3, 2020
@joshtemple joshtemple mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshtemple joshtemple

Labels
Bug Something isn't working
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Fix hybrid mode not returning dimensional errors spectacles-ci/spectacles
2 participants
@joshtemple @DylanBaker