-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint command to validate project markup. #309
Comments
I've looked at this before but was unclear what benefit adding this to Spectacles brings since you have to pass this check to commit code in the Looker IDE. Are you deploying LookML that's not going through that validation step in the IDE? |
Correct, well I do anyway: often creating/editing files and pushing the changes from outside the UI. Others that do tend to work though the UI don't always remember to validate their changes before opening a PR and possibly merging in broken changes. I guess the real question is why we don't have that setting better configured, I'll have to follow up with my team mates to figure out if there was some reason we don't have it set to require errors to be fixed. |
I just wanted to +1 this issue as it's something we would like to have as well. In response to the comments above. I also just want to note the following:
So the lint validation would be quite valuable. (I saw it noted as coming soon. Is there a timeline for this?) |
We've got this work done (see #422), we just need to add some tests and get it merged and it will go out in the next release. Should be done this month. |
Awesome! Thank you! |
re: https://docs.looker.com/reference/api-and-integration/api-reference/v3.1/project#validate_project
It'd be very nice to be able to perform the same lint check you can do in the UI by clicking the "Code Validator" button via the CI/CD process.
The text was updated successfully, but these errors were encountered: