-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/log time assert #134
Feature/log time assert #134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
+ Coverage 66.52% 66.8% +0.28%
=========================================
Files 9 9
Lines 684 717 +33
=========================================
+ Hits 455 479 +24
- Misses 229 238 +9
Continue to review full report at Codecov.
|
@Hawk94 Thanks for this! It looks good. One thing I can't decide is if the time should be how long the whole process takes, or just the validate step. There's a bit of time spent building up the LookML project, that doesn't get included if we just wrap the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @Hawk94! I think measuring validate
is good enough. There isn't that much happening outside of that method except for instantiation of the client and branch checkout.
There's a bit of time spent building up the LookML project
This actually happens in the validate
method, so we're covered here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, @DylanBaker pointed out we should decorate the validate_*
methods in the Runner
class, not the validate
methods of the Validators. I'm assuming that's a straightforward change and helps capture more of the runtime.
…e setup of the project
Extend log_time decorator to handle logging from multiple different validators. Also align output from
spectacles assert
&spectacles sql
commands: