-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content validator #236
Conversation
This PR needs tests before it's ready for review. |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 89.71% 89.84% +0.12%
==========================================
Files 13 17 +4
Lines 1060 1241 +181
==========================================
+ Hits 951 1115 +164
- Misses 109 126 +17
Continue to review full report at Codecov.
|
9d4bc83
to
1d52909
Compare
Use tmpdir for SQL logging Try creating parents too Mock logging call
ef1ee23
to
07a80ab
Compare
@DylanBaker, there are a few limitations to this validator in the current state:
|
@joshtemple Thanks. That makes sense. It sounds like we could solve both those issues if we could convince Looker to return the project name from that endpoint? |
0fdf28b
to
07d71dd
Compare
Closes #138.
Adds a validator for content validation
spectacles content
with the following validator-specific parameters:--incremental
: ignore errors that are already present in production--exclude-personal
: ignore errors in content in personal foldersThere are a couple other notable differences from the Looker content validator:
--explores
and--exclude
to test specific LookML for content issues--project
instead of for the entire instanceMisc changes also included in this PR:
log_duration
moved to the CLI functions instead of the Runner methods