Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeout for LookML validation #670

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

joshtemple
Copy link
Collaborator

Change description

When we make requests to the LookML validation endpoint, we use the default Spectacles timeout of 300 seconds (5 minutes). This is too short for some instances with long validation times, so this change extends the timeout for that request to 30 minutes.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@joshtemple joshtemple merged commit a52f428 into master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants