Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeout for LookML validation #670

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Extend timeout for LookML validation #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d61de
Update hook location for flake8
joshtemple Dec 2, 2022
d137834
Lengthen LookML validator timeout to 30m
joshtemple Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@ repos:
- repo: https://github.com/ambv/black
rev: 22.3.0
hooks:
- id: black
- repo: https://gitlab.com/pycqa/flake8
- id: black
- repo: https://github.com/PyCQA/flake8
rev: 4.0.1
hooks:
- id: flake8
- id: flake8
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.961
hooks:
- id: mypy
args: [--ignore-missing-imports]
additional_dependencies:
- 'types-requests==2.25.11'
- 'types-tabulate==0.8.3'
- 'types-PyYAML==6.0.0'
- 'pydantic==1.9.0'
- id: mypy
args: [--ignore-missing-imports]
additional_dependencies:
- "types-requests==2.25.11"
- "types-tabulate==0.8.3"
- "types-PyYAML==6.0.0"
- "pydantic==1.9.0"
4 changes: 2 additions & 2 deletions spectacles/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@ async def content_validation(self) -> JsonDict:
async def lookml_validation(self, project) -> JsonDict:
logger.debug(f"Validating LookML for project '{project}'")
url = utils.compose_url(self.api_url, path=["projects", project, "validate"])
response = await self.post(url=url, timeout=TIMEOUT_SEC)
response = await self.post(url=url, timeout=1800)

try:
response.raise_for_status()
Expand All @@ -883,7 +883,7 @@ async def lookml_validation(self, project) -> JsonDict:
async def cached_lookml_validation(self, project) -> Optional[JsonDict]:
logger.debug(f"Getting cached LookML validation results for '{project}'")
url = utils.compose_url(self.api_url, path=["projects", project, "validate"])
response = await self.get(url=url, timeout=TIMEOUT_SEC)
response = await self.get(url=url, timeout=1800)

try:
response.raise_for_status()
Expand Down