Remove unneeded casts in page.getParam #2186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Curious how you found these. Are you using a linter? |
|
Just caught my eye when looking at Page's implementation. Why do you ask? |
|
Then you have a good eye. 👍 I was asking about the linter because I don't know of an existing linter that would detect that issue. lgtm |
|
Force pushed to my fork like an idiot and got another commit stuck in the mix, no changes in the new version |
tychoish
pushed a commit
to tychoish/hugo
that referenced
this pull request
Aug 13, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some calls to cast.To in getParam are no-ops that can be removed, since they just add type information that is discarded on return