Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/public is added to watchlist #2602

Closed
bep opened this issue Oct 18, 2016 · 4 comments
Closed

/public is added to watchlist #2602

bep opened this issue Oct 18, 2016 · 4 comments
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Oct 18, 2016

Noticed this when having hugo server and doing a hugo on the side:

adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/errors
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate/fonts
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate/images
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate/javascripts
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate/javascripts/app
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate/javascripts/lib
adding created directory to watchlist /Users/bep/sites/hugo-slate/exampleSite/public/slate/stylesheets

That doesn't sound right.

@bep bep added the Bug label Oct 18, 2016
@Imhotup
Copy link

Imhotup commented Oct 18, 2016

Hi @bep Are there any files I should look at to fix this?

@bep
Copy link
Member Author

bep commented Oct 18, 2016

@Imhotup I will have to think about this ... this may be as designed, but still is unfortunate. We are listening for changes in the site root for config.toml, and the watches seems to be recursive by default.

@bep
Copy link
Member Author

bep commented Oct 19, 2016

OK, I see what's happening now.

I was doing some work in a theme, so I have

myTheme/exampleSite

and set

themesdir = "../.."

In the exampleSite to test it.

This works fine, but he/she who made the watcher dir logic for themes was lazy (probably me, then :-)) and added the entire theme dir to watch list, while doing the proper thing for the base project (adding static, content etc.)

While this works, it is annoying when you have stuff like /assets/javascript etc. that you don't want to trigger reloads.

@bep bep added this to the v0.18 milestone Oct 19, 2016
@bep bep self-assigned this Oct 19, 2016
@bep bep closed this as completed in f0af807 Oct 19, 2016
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
The same behavior as for the root project.

Fixes gohugoio#2602
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants