Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Site.LastChange should be time of newest content #2909

Closed
moorereason opened this issue Jan 7, 2017 · 2 comments · Fixed by #3058
Closed

.Site.LastChange should be time of newest content #2909

moorereason opened this issue Jan 7, 2017 · 2 comments · Fixed by #3058
Assignees
@moorereason
Labels
Bug Outdated
Milestone
v0.19

Comments

@moorereason
Copy link
Contributor

Currently, .Site.LastChange is set to the first page in the default sort order (hugolib/site.go#L135), which may not be the most recent content if weights were added to the front matter.

See https://discuss.gohugo.io/t/4992
@moorereason moorereason added the Bug label Jan 7, 2017
@moorereason moorereason self-assigned this Jan 7, 2017
@moorereason moorereason added this to the v0.19 milestone Jan 7, 2017
@moorereason
Copy link
Contributor Author

Also seen here: musec/hugo-memorial-theme@f5c1728

@moorereason moorereason mentioned this issue Jan 7, 2017
Closed
moorereason added a commit to moorereason/hugo that referenced this issue Feb 18, 2017
@moorereason
hugolib: Fix .Site.LastChange setting
d382af7 
If weights are added to the content front matter, the default sort order
can't be relied upon to set `.Site.LastChange`.

Fixes gohugoio#2909
@bep bep mentioned this issue Feb 19, 2017
Merged
bep added a commit to bep/hugo that referenced this issue Feb 19, 2017
@bep
hugolib: Fix .Site.LastChange
e8e9a78 
This commit makes sure that the `.Site.LastChange` is fetched from the latest page modification date.

Previously, this value was fetched from the last page in the default page sort, which may not be the last by date
if weight is set.

Fixes gohugoio#2909
Closes gohugoio#2910
@bep bep closed this as completed in #3058 Feb 19, 2017
bep added a commit that referenced this issue Feb 19, 2017
@bep
hugolib: Fix .Site.LastChange
6809ea1 
This commit makes sure that the `.Site.LastChange` is fetched from the latest page modification date.

Previously, this value was fetched from the last page in the default page sort, which may not be the last by date
if weight is set.

Fixes #2909
Closes #2910
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moorereason moorereason

Labels
Bug Outdated
Projects
None yet
Milestone
v0.19
1 participant
@moorereason