Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RSS pages limit configurable #3035

Closed
AlekSi opened this issue Feb 13, 2017 · 1 comment · Fixed by #3036
Closed

Make RSS pages limit configurable #3035

AlekSi opened this issue Feb 13, 2017 · 1 comment · Fixed by #3036
Assignees
@moorereason
Labels
Enhancement Outdated
Milestone
v0.19

Comments

@AlekSi
Copy link

AlekSi commented Feb 13, 2017

Currently, there is a hard limit of 50 pages for RSS. I discovered it while investigating a report about iTunes Store removing old episodes of our podcast.

Please make this limit configurable.
@moorereason moorereason mentioned this issue Feb 13, 2017
Merged
@moorereason moorereason self-assigned this Feb 13, 2017
moorereason added a commit to moorereason/hugo that referenced this issue Feb 17, 2017
@moorereason
hugolib: Make RSS item limit configurable
edaeeea 
Add a new rssLimit site configuration option with default of 15.  Prior
to this fix, you could create your own RSS feed to override the default
limit of 15, but we still had a hardcoded limit of 50 items set in
`hugolib.renderRSS()`.

With this option in place, the `range first 15 .Data.Pages` logic is no
longer hardcoded into the embedded RSS template.

Because the size of the slice passed to the template is now limited to
rssLimit instead of 50, this commit is a breaking change for sites
with a custom RSS template that expects more than 15 items.

Fixes gohugoio#3035
@bep bep added this to the v0.19 milestone Feb 17, 2017
@bep bep closed this as completed in #3036 Feb 17, 2017
bep pushed a commit that referenced this issue Feb 17, 2017
@moorereason @bep
hugolib: Make RSS item limit configurable
10c13f5 
Add a new rssLimit site configuration option with default of 15.  Prior
to this fix, you could create your own RSS feed to override the default
limit of 15, but we still had a hardcoded limit of 50 items set in
`hugolib.renderRSS()`.

With this option in place, the `range first 15 .Data.Pages` logic is no
longer hardcoded into the embedded RSS template.

Because the size of the slice passed to the template is now limited to
rssLimit instead of 50, this commit is a breaking change for sites
with a custom RSS template that expects more than 15 items.

Fixes #3035
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moorereason moorereason

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.19
Development

Successfully merging a pull request may close this issue.

hugolib: Make RSS item limit configurable moorereason/hugo
3 participants
@AlekSi @moorereason @bep