This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
[PubsubPluginSink] Drop requests greater than MAX_INPUT_METRICS #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final ByteString mResize = ByteString.copyFrom(serializer.serialize(l, writeCache)); | ||
| publishPubSub(mResize); | ||
| } catch (Exception e) { | ||
| logger.error("Failed to serialize batch of metrics: ", e); |
There was a problem hiding this comment.
should we throw an HttpException where we're catching these exceptions?
There was a problem hiding this comment.
I don't think this is in the path of HTTP requests, the input plugins are done once ffwd has buffered the metrics internally.
There was a problem hiding this comment.
I don't think I can throw an exception at that point, we'd need to figure out the size sooner somewhere upstream
hexedpackets
approved these changes
Feb 26, 2021
lmuhlha
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.