Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on kuberenetes deployment properites #503

Closed
markpollack opened this issue Jul 27, 2022 · 1 comment
Closed

Improve documentation on kuberenetes deployment properites #503

markpollack opened this issue Jul 27, 2022 · 1 comment
Assignees
Labels
status/in-progress Something is happening
Milestone

Comments

@markpollack
Copy link
Contributor

Many of the kubernetes deployment property keys take a JSON string as their value. This creates a bit of friction as all examples that are cut-n-pasted from k8s docs that are in YAML. Volume mounts are a good example. The JavaDoc for the deployer has many examples that should be surfaced in dataflow.spring.io, e.g. https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/blob/main/src/main/java/org/springframework/cloud/deployer/spi/kubernetes/DeploymentPropertiesResolver.java#L117

@markpollack markpollack added this to the General Backlog milestone Jul 27, 2022
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jul 27, 2022
@markpollack markpollack modified the milestones: General Backlog, 2.8.0 Oct 18, 2022
@corneil
Copy link
Contributor

corneil commented Dec 5, 2022

Updating reference documentation on Getting Started for Kubernetes to point to the Configuration - Kubernetes section which has information on the deployment properties.

@corneil corneil closed this as completed Dec 5, 2022
@corneil corneil added status/in-progress Something is happening and removed status/need-triage Team needs to triage and take a first look labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/in-progress Something is happening
Projects
None yet
Development

No branches or pull requests

2 participants