Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Cloud Azure 4.0.0 #871

Closed
saragluna opened this issue Mar 22, 2022 · 9 comments
Closed

Upgrade to Spring Cloud Azure 4.0.0 #871

saragluna opened this issue Mar 22, 2022 · 9 comments
Assignees

Comments

@saragluna
Copy link

saragluna commented Mar 22, 2022

We are going to GA the next major version of Spring Cloud Azure later this month, and this version will have breaking changes in both artifact names and APIs. The next major version will be 4.0.0 and it's compatible with Spring Boot 2.5.x and 2.6.x, and we have released several beta versions already. So I am reaching out before the GA release to discuss the changes.

@saragluna
Copy link
Author

Hi @snicoll, the release has finished. Could you help update the entries with the following changes?

@snicoll snicoll changed the title Upgrade to Spring Cloud Azure 4.0 Upgrade to Spring Cloud Azure 4.0.0 Apr 1, 2022
@snicoll snicoll self-assigned this Apr 1, 2022
@snicoll snicoll closed this as completed in 59e3c45 Apr 1, 2022
@snicoll
Copy link
Contributor

snicoll commented Apr 1, 2022

@saragluna it would be nice if we had links to samples that are not pointing directly to a GitHub folder. Right now the samples are pointing to a branch, which can I see being changed and break. Would it be possible to add links to samples in the reference guide maybe?

@saragluna
Copy link
Author

saragluna commented Apr 1, 2022

Hi @snicoll, could you point out to me which links are broken now? And what is the reference guide link? Now our samples link to this tag https://github.com/Azure-Samples/azure-spring-boot-samples/releases/tag/spring-cloud-azure_4.0.0, and reference doc is here https://aka.ms/spring/docs/4.0.0.

@snicoll
Copy link
Contributor

snicoll commented Apr 1, 2022

They aren't any broken links. I could add links to sample using https://github.com/Azure-Samples/azure-spring-boot-samples/releases/tag/spring-cloud-azure_4.0.0 but I am not feeling comfortable doing so as they are for a fixed version and I'd rather have something that evolves over time.

Ideally we should be able to add a token to replace the version in the URL but we don't have that feature yet.

@saragluna
Copy link
Author

@snicoll how about using this https://aka.ms/spring/samples, it will point to our sample repo.

@snicoll
Copy link
Contributor

snicoll commented Apr 1, 2022

It's not a link to "the samples". We need a link to "a sample". Each entry can have a number of links. One for the documentation, one for the sample, etc. Try it out on start.spring.io for more details.

@saragluna
Copy link
Author

Hi @snicoll, one more question about the site, when I choose the Azure Support with Azure Cosmos it uses version 4.0.0, but when I remove either one of them, it uses version 3.14.0. Is it because of some cached value?

image

image

@snicoll
Copy link
Contributor

snicoll commented Apr 1, 2022

Thanks for those links! I've added them in 910573d

As for serving 3.14.0 still, it looks a pod is still running with the previous bits. We're investigating.

EDIT: the pods are up-to-date but we're hitting a cache problem that is web specific. If you try from the command-line or from an IDE, it should work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants