Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Date/Time formatting tests to accommodate narrow non-breaking spaces #33144

Closed
snicoll opened this issue Jul 4, 2024 · 2 comments
Closed

Adapt Date/Time formatting tests to accommodate narrow non-breaking spaces #33144

snicoll opened this issue Jul 4, 2024 · 2 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Milestone
6.1.11

Comments

@snicoll
Copy link
Member

snicoll commented Jul 4, 2024 •
edited by sbrannen
Loading

Overview

We have a number of tests that assert that a converted time ends with specific content, such as "12:00:00 PM" (with a standard space instead of a narrow non-breaking space (NNBSP)).

In Java 20, the space between the time and PM was changed to an NNBSP, and the assertions fail for that reason only. We should find a way to make those tests more robust to that change.

And in Java 23, the support for using legacy locale data for Date/Time parsing and formatting was removed. In other words, the -Djava.locale.providers=COMPAT command-line argument is no longer supported.

This is required to run CI on Java 23 ea.

Related Issues
@snicoll snicoll added the type: task A general task label Jul 4, 2024
@snicoll snicoll added this to the 6.1.x milestone Jul 4, 2024
@snicoll snicoll self-assigned this Jul 4, 2024
@snicoll

This comment was marked as outdated.

Sign in to view
@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
@snicoll snicoll removed this from the 6.1.x milestone Jul 4, 2024
@snicoll snicoll added the status: duplicate A duplicate of another issue label Jul 4, 2024
@snicoll

This comment was marked as outdated.

Sign in to view
@snicoll snicoll reopened this Jul 4, 2024
@snicoll snicoll removed the status: duplicate A duplicate of another issue label Jul 4, 2024
@snicoll snicoll added this to the 6.1.x milestone Jul 4, 2024
@sbrannen sbrannen assigned sbrannen and unassigned snicoll Jul 4, 2024
@sbrannen sbrannen modified the milestones: 6.1.x, 6.1.11 Jul 4, 2024
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Jul 4, 2024
@snicoll snicoll mentioned this issue Jul 4, 2024
Closed
@sbrannen sbrannen changed the title Adapt tests that assert a formatted date ends with a specific String to be more robust Adapt Date/Time formatting tests to accommodate narrow non-breaking spaces Jul 4, 2024
This was referenced Jul 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
6.1.11
Development

No branches or pull requests
2 participants
@sbrannen @snicoll