Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging AuthenticationManager and AuthenticationProvider #13270

Open
Tracked by #13266
jgrandja opened this issue Jun 2, 2023 · 4 comments
Open
Tracked by #13266

Consider merging AuthenticationManager and AuthenticationProvider #13270

jgrandja opened this issue Jun 2, 2023 · 4 comments
Labels
theme: partner-use-cases Use cases we identified with a partner (an established contributor) type: enhancement A general enhancement

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Jun 2, 2023

We should consider merging AuthenticationManager and AuthenticationProvider into a single interface, since both APIs are almost identical.

We should also consider introducing a more generalized API, for example, Authenticator, and discontinue usage of AuthenticationManager and AuthenticationProvider.

Related gh-13266, gh-11428

@jgrandja jgrandja added the type: enhancement A general enhancement label Jun 2, 2023
@asaikali
Copy link

asaikali commented Jun 5, 2023

It would be nice to make sure that the javadocs for the AuthenticationManager and AuthenticationProvider are updated with commentary that explains the differences between these interfaces. For the simplification effort would be great to have docs that explain the why behind the decisions that are easy to find.

@jzheaux
Copy link
Contributor

jzheaux commented Jun 7, 2023

Is this a duplicate of #11428? If not, it should probably at least be referenced in the description, as you've done in the other Improve Usability tickets.

@jgrandja
Copy link
Contributor Author

jgrandja commented Jun 8, 2023

@jzheaux It's not a duplicate. I referenced it in the description as it is related.

@sjohnr sjohnr added the theme: partner-use-cases Use cases we identified with a partner (an established contributor) label Jul 6, 2023
@abccbaandy
Copy link

Agree, as an user, it's very unintuitive to have two different name but do the almost same thing class.

Also please consider AuthorizationManager when you design the new api, I think Authorization and Authentication should have the same naming and the same api, at least should looks almost the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: partner-use-cases Use cases we identified with a partner (an established contributor) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants