Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to article with remember-me-persistent-token strategy is broken #14358

Closed
ram0973 opened this issue Dec 21, 2023 · 2 comments
Closed

Link to article with remember-me-persistent-token strategy is broken #14358

ram0973 opened this issue Dec 21, 2023 · 2 comments
Assignees
@marcusdacoregio
Labels
in: docs An issue in Documentation or samples status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: bug A general bug
Milestone
5.8.13

Comments

@ram0973
Copy link

ram0973 commented Dec 21, 2023 •
edited
Loading

Here
https://docs.spring.io/spring-security/reference/servlet/authentication/rememberme.html#remember-me-persistent-token
is link to article
http://jaspan.com/improved_persistent_login_cookie_best_practice
Site (jaspan.com) can't be opened and is requesting a login.
Maybe, we can add a link to original article, and additions from web-archive?
https://fishbowl.pastiche.org/2004/01/19/persistent_login_cookie_best_practice
https://web.archive.org/web/20180819014446/http://jaspan.com:80/improved_persistent_login_cookie_best_practice
@ram0973 ram0973 added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Dec 21, 2023
@marcusdacoregio marcusdacoregio self-assigned this Apr 10, 2024
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Apr 10, 2024
@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Apr 30, 2024 •
edited
Loading

Hi @ram0973, are you interested in submitting a PR to fix it? Ideally, the PR should target the oldest branch that contains the bug which in this case should be 5.8.x.

@marcusdacoregio marcusdacoregio added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Apr 30, 2024
@YangSiJun528
Copy link
Contributor

YangSiJun528 commented May 23, 2024 •
edited
Loading

The issue has been fixed in 5.8.x by this commit.
However, this change doesn't seem to be reflected from the 6.0.x version onwards.

@marcusdacoregio marcusdacoregio added this to the 5.8.13 milestone May 23, 2024
@marcusdacoregio marcusdacoregio mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: bug A general bug
Projects
Spring Security Team
Status: No status
Milestone
5.8.13
Development

No branches or pull requests
3 participants
@ram0973 @marcusdacoregio @YangSiJun528