Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention all required dependencies in LDAP documentation #14699

Closed
Harsh4902 opened this issue Mar 7, 2024 · 5 comments
Closed

Mention all required dependencies in LDAP documentation #14699

Harsh4902 opened this issue Mar 7, 2024 · 5 comments
Assignees
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement
Milestone

Comments

@Harsh4902
Copy link
Contributor

Harsh4902 commented Mar 7, 2024

Expected Behavior

  • I think we should mention all the required dependencies in this documentation so it will be more helpfull.

Current Behaviour

  • There is no mention of spring-security-ldap dependency in this document, though it is required.

Context

  • I was trying to do basic LDAP setup and going through this documentation I added some dependencies, but I was not aware about to add spring-security-ldap. This thing put me in trouble, and then I had to go through some other blogs and videos. So it's my suggestion to add all the required dependencies so it can be easy for users.
@Harsh4902 Harsh4902 added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Mar 7, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Apr 10, 2024

I agree, @Harsh4902. Would you be able to contribute a PR that adds it to this section? Ideally, please make the change on the 5.8.x branch so we can forward port it after merging.

@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Apr 10, 2024
@jzheaux jzheaux added this to the 5.8.12 milestone Apr 10, 2024
@jzheaux jzheaux added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Apr 10, 2024
@Harsh4902
Copy link
Contributor Author

@jzheaux Sure I will raise a PR for this issue. Give me some time, thank you.

@sjohnr sjohnr modified the milestones: 5.8.12, 5.8.13 Apr 15, 2024
@Harsh4902
Copy link
Contributor Author

@jzheaux Can I describe required dependencies in Prerequisites section of this document?

@jzheaux
Copy link
Contributor

jzheaux commented Jun 6, 2024

@Harsh4902, sorry that I missed your message. I think it would be better in https://docs.spring.io/spring-security/reference/servlet/authentication/passwords/ldap.html#servlet-authentication-ldap-embedded or in a new section in between the two. The PreRequisites section seems to be more about architectural groundwork.

@jzheaux jzheaux added type: enhancement A general enhancement and removed type: bug A general bug status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jun 6, 2024
@Harsh4902
Copy link
Contributor Author

@jzheaux Thanks, I will add new section for this and will send PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants