Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters customizer called before all parameters are set #15939

Closed
sjohnr opened this issue Oct 17, 2024 · 0 comments
Closed

Parameters customizer called before all parameters are set #15939

sjohnr opened this issue Oct 17, 2024 · 0 comments
Assignees
@sjohnr
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
6.4.0-RC1

Comments

@sjohnr
Copy link
Member

sjohnr commented Oct 17, 2024 •
edited
Loading

The parametersCustomizer in DefaultOAuth2TokenRequestParametersConverter cannot customize parameters that are added afterwards. The customizer can be moved to AbstractRestClientOAuth2AccessTokenResponseClient and AbstractWebClientReactiveOAuth2AccessTokenResponseClient to allow customizing all parameters.
@sjohnr sjohnr self-assigned this Oct 17, 2024
@sjohnr sjohnr converted this from a draft issue Oct 17, 2024
@sjohnr sjohnr moved this to In Progress in Spring Security Team Oct 17, 2024
@sjohnr sjohnr added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Oct 17, 2024
@sjohnr sjohnr added this to the 6.4.0-RC1 milestone Oct 17, 2024
@sjohnr sjohnr closed this as completed in dab6950 Oct 18, 2024
@sjohnr sjohnr moved this from In Progress to Done in Spring Security Team Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
6.4.0-RC1
Development

No branches or pull requests
1 participant
@sjohnr