Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DefaultReactiveOAuth2UserService handling IOException #7370

Closed
rwinch opened this issue Sep 5, 2019 · 0 comments
Closed

Improve DefaultReactiveOAuth2UserService handling IOException #7370

rwinch opened this issue Sep 5, 2019 · 0 comments
Assignees
@rwinch
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0.RC1

Comments

@rwinch
Copy link
Member

rwinch commented Sep 5, 2019

Summary

There are many reasons that a DefaultReactiveOAuth2UserService might fail due to an IOException (i.e. SSLHandshakeException). In those cases we should use a AuthenticationServiceException so that users are aware there is likely some misconfiguration.
@rwinch rwinch added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Sep 5, 2019
@rwinch rwinch added this to the 5.2.0.RC1 milestone Sep 5, 2019
@rwinch rwinch self-assigned this Sep 5, 2019
@rwinch rwinch closed this as completed in 2a3bf9b Sep 5, 2019
@jzheaux jzheaux changed the title Improvate DefaultReactiveOAuth2UserService handling IOException Improve DefaultReactiveOAuth2UserService handling IOException Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.RC1
Development

No branches or pull requests
1 participant
@rwinch