Resolve oauth2 client-id, client-secret placeholders #8880
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
Thanks for the PR @evgeniycheban. Please see my one comment.
| @@ -104,8 +105,10 @@ public BeanDefinition parse(Element element, ParserContext parserContext) { | |||
| } | |||
| } | |||
| getOptionalIfNotEmpty(clientRegistrationElt.getAttribute(ATT_CLIENT_ID)) | |||
| .map(parserContext.getReaderContext().getEnvironment()::resolvePlaceholders) | |||
There was a problem hiding this comment.
There may be other placeholders that need to be resolved other than client-id and client-secret and I would like to avoid adding parserContext.getReaderContext().getEnvironment()::resolvePlaceholders to every element.
If you look at this commit, could we simply register a org.springframework.beans.factory.config.PropertyPlaceholderConfigurer @Bean to take care of it?
There was a problem hiding this comment.
Thanks for the review @jgrandja.
In this case, we do not register ClientRegistration as a bean, so we need to manually resolve property placeholders.
Maybe it would be better to move parserContext.getReaderContext().getEnvironment()::resolvePlaceholders to getOptionalIfNotEmpty method?
There was a problem hiding this comment.
Yes you are right @evgeniycheban - ClientRegistration are not beans so that won't work.
Maybe it would be better to move
parserContext.getReaderContext().getEnvironment()::resolvePlaceholderstogetOptionalIfNotEmptymethod?
Agreed.
jgrandja
added
in: oauth2
evgeniycheban
force-pushed
the
gh-8453
branch
2 times, most recently
from
2f9069c to
bca066d
Compare
evgeniycheban
force-pushed
the
gh-8453
branch
2 times, most recently
from
4482e8a to
b0f45d8
Compare
|
Thanks for the PR @evgeniycheban ! This is now in master. |
Closes gh-8453