Unable to determine if it is a Kotlin type

[mymx2]

Unable to determine if it is a Kotlin type

• method: SpringDocKotlinConfiguration.nullableKotlinRequestParameterCustomizer
• lineNum: 78
  

To Reproduce
Steps to reproduce the behavior:

• What version of spring-boot you are using?
  • 3.2.4
• What modules and versions of springdoc-openapi are you using?
  • 2.4.0
• What is the actual and the expected result using OpenAPI Description (yml or json)?
  • kotlin type isMarkedNullable
• Provide with a sample code (HelloController) or Test that reproduces the problem

interface AdminSysNoticePage {

  @Operation(summary = "adminSysNoticePage", description = "adminSysNoticePage")
  @GetMapping("adminSysNoticePage")
  fun adminSysNoticePage(
    @Validated request: AdminSysNoticePageRequest
  ): AdminSysNoticePageResponse
}

@Schema(description = "AdminSysNoticePageRequest")
data class AdminSysNoticePageRequest(

  @field:Schema(description = "id not required", example = "")
  var id: Long? = null,

  @field:Schema(description = "noticeTitle is required", example = "")
  var noticeTitle: String,
)

@Schema(description = " AdminSysNoticePageResponse")
data class AdminSysNoticePageResponse(

  @field:Schema(description = "id is required", example = "")
  var id: Long,

  @field:Schema(description = "updateBy is not required", example = "")
  var updateBy: String? = null,
)

Screenshots

• wrong: KotlinDetector.isKotlinType(methodParameter.parameterType)
  

• right: KotlinDetector.isKotlinType(methodParameter.containingClass)
  

• fix: KotlinDetector.isKotlinType(methodParameter.containingClass)
  

is this fix code right?

Additional context
id dont know what fix use methodParameter.toKParameter() ?

[bnasslahsen]

@mymx2,

See the follwing tests:

springdoc-openapi/springdoc-openapi-tests/springdoc-openapi-kotlin-webmvc-tests/src/test/kotlin/test/org/springdoc/api/app9/DemoController.kt

Lines 21 to 71 in 1ca8bc5

	class DemoRequest (
	@field:Schema(required = true, defaultValue = "a default value")
	val requiredNullableDefault: String?,
	@field:Schema(required = true)
	val requiredNullableNoDefault: String?,
	@field:Schema(required = true, defaultValue = "a default value")
	val requiredNoNullableDefault: String,
	@field:Schema(required = true)
	val requiredNoNullableNoDefault: String,
	@field:Schema(requiredMode = Schema.RequiredMode.REQUIRED, defaultValue = "a default value")
	val requiredNullableDefault1: String?,
	@field:Schema(requiredMode = Schema.RequiredMode.REQUIRED)
	val requiredNullableNoDefault1: String?,
	@field:Schema(requiredMode = Schema.RequiredMode.REQUIRED, defaultValue = "a default value")
	val requiredNoNullableDefault1: String,
	@field:Schema(requiredMode = Schema.RequiredMode.REQUIRED)
	val requiredNoNullableNoDefault1: String,
	@field:Schema(requiredMode = Schema.RequiredMode.NOT_REQUIRED, defaultValue = "a default value")
	val noRequiredNullableDefault2: String?,
	@field:Schema(requiredMode = Schema.RequiredMode.NOT_REQUIRED)
	val noRequiredNullableNoDefault2: String?,
	@field:Schema(requiredMode = Schema.RequiredMode.NOT_REQUIRED, defaultValue = "a default value")
	val noRequiredNoNullableDefault2: String,
	@field:Schema(requiredMode = Schema.RequiredMode.NOT_REQUIRED)
	val noRequiredNoNullableNoDefault2: String,
	@field:Schema(defaultValue = "a default value")
	val noRequiredNullableDefault: String?,
	@field:Schema
	val noRequiredNullableNoDefault: String?,
	@field:Schema(defaultValue = "a default value")
	val noRequiredNoNullableDefault: String,
	@field:Schema
	val noRequiredNoNullableNoDefault: String,
	)

Tests are following the test cases described here:

• Fix behaviuor of required flag for schema class fields. #2185

If you see any case, not respected, make sure you update the test and we can consider it.

[codespearhead]

@mymx2 Try using JDK 17, because JDK 21 isn't yet supported as per #2442 .

[mymx2]

@mymx2 Try using JDK 17, because JDK 21 isn't yet supported as per #2442 .

i try add more cases...

more than:

this cases not include @Parameter annotaion

[codespearhead]

I see.

I suggest forking this repository, updating the test suite so that there are failing tests and creating a draft PR linked to this issue, so we can take a look.