Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperatures #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix temperatures #29

wants to merge 3 commits into from

Conversation

spuder
Copy link
Owner

@spuder spuder commented Jan 14, 2025

Resolves #28

@raihei
Copy link
Contributor

raihei commented Jan 18, 2025

@spuder Any reason you did not merge this pull request yet? I tested it and it works for me.

@spuder
Copy link
Owner Author

spuder commented Jan 21, 2025

The actual bug is in in the automation.yaml, pushed a new change that removes the upload button.

@raihei
Copy link
Contributor

raihei commented Jan 21, 2025

Sorry, I don't get it. Why not push that fix in the main branch? And why remove the button?

@spuder
Copy link
Owner Author

spuder commented Jan 21, 2025

I'm sitting on the branch because I haven't had time to test it yet

That button is a legacy button that wasn't really intended to be used. If people use it we could leave it however it has a completely different code path that would need to be refactored.

@raihei
Copy link
Contributor

raihei commented Jan 21, 2025

I see, thanks for clarifying. That's true, it is probably rarely used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Button uses wrong temperature
2 participants