Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2 readSettings() throws invalid parameter id when unknown settings encountered #2282

Closed
jk0204 opened this issue Jan 26, 2016 · 1 comment

Comments

@jk0204
Copy link

jk0204 commented Jan 26, 2016

We are using OkHttp2 to talk to a service configured using IIS. It works fine with Android 4.x, but on Android 5.0 and above, the connection is always closed by the client.

The issue turns out to be that the frame returned back from the service contains a setting with id 16, which is not defined in https specification, thus OkHttp's http2 readSettings() method throws invalid parameter exception.

According to the RFC (https://tools.ietf.org/html/rfc7540#section-6.5.2), unknown parameter should be ignored, so would it be better to ignore and continue in this case instead of throwing the exception?

@swankjesse
Copy link
Collaborator

Yup, that's our bug. Will fix. If you wanna send a pull request with a test case, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants