Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document lack of support for [email protected] notation #124

Open
jsoref opened this issue May 18, 2022 · 0 comments
Open

Document lack of support for [email protected] notation #124

jsoref opened this issue May 18, 2022 · 0 comments

Comments

@jsoref
Copy link

jsoref commented May 18, 2022

GitHub's CODEOWNERS files support this notation:

In most cases, you can also refer to a user by an email address that has been added to their account on GitHub.com, for example [email protected].

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

The code in trimUsername will do something inconsistent with GitHub's behavior for [email protected]:

robot-overlord/src/utils.ts

Lines 121 to 122 in e60c44e

export const trimUsername = (original: string): string => {
const match = original.match(/[\w-/]+/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant