From 6c9b32666c82569326e534013abcc8b343e20834 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Bundyra?= Date: Fri, 29 Nov 2019 11:10:49 +0000 Subject: [PATCH] Variable `$this` must be lowercase, PHP is case sensitive for variables --- src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php | 2 +- src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php b/src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php index ee671dfed5..aab8504bbc 100644 --- a/src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php +++ b/src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php @@ -75,7 +75,7 @@ public function processTokenWithinScope(File $phpcsFile, $stackPtr, $currScope) } else if ($tokens[$next]['code'] === T_ANON_CLASS) { $next = $tokens[$next]['scope_closer']; continue; - } else if (strtolower($tokens[$next]['content']) !== '$this') { + } else if ($tokens[$next]['content'] !== '$this') { continue; } diff --git a/src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc b/src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc index 1a6ca7e098..38b443f2fd 100644 --- a/src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc +++ b/src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc @@ -108,4 +108,10 @@ $b = new class() }) { }; } + + public static function thisMustBeLowercase() { + $This = 'hey'; + + return $This; + } }