From 898d911b988ac2adc196db8a4bd257683778a64e Mon Sep 17 00:00:00 2001
From: Thiemo Kreuz <thiemowmde@users.noreply.github.com>
Date: Wed, 17 Jun 2020 09:22:09 +0200
Subject: [PATCH] Fix InlineControlStructureSniff adding brackets when there is
 already a bracket
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

While live coding, there might not only be an incomplete `if ():` at the end of a file, it might as well be an incomplete `if () {`. The most minimal example I found is `<?php if ( 1 ) { break;`. The auto-fix currently turns this into `<?php if ( 1 ) { { { { { { { { { { { { { { { { { { { { { { { { { { break;}}}}}}}}}}}}}}}}}}}}}}}}}`. 😲
---
 .../ControlStructures/InlineControlStructureSniff.php       | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php b/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php
index d48a477ce1..19a58833be 100644
--- a/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php
+++ b/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php
@@ -142,8 +142,10 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        if ($tokens[$nextNonEmpty]['code'] === T_COLON) {
-            // Alternative control structure.
+        if ($tokens[$nextNonEmpty]['code'] === T_OPEN_CURLY_BRACKET
+            || $tokens[$nextNonEmpty]['code'] === T_COLON
+        ) {
+            // T_CLOSE_CURLY_BRACKET missing, or alternative control structure with
             // T_END... missing. Either live coding, parse error or end
             // tag in short open tags and scan run with short_open_tag=Off.
             // Bow out completely as any further detection will be unreliable