Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: inconsistent path filtering #226

Open
bzz opened this issue Apr 16, 2019 · 1 comment
Open

CLI: inconsistent path filtering #226

bzz opened this issue Apr 16, 2019 · 1 comment
Labels

Comments

@bzz
Copy link
Contributor

bzz commented Apr 16, 2019

Steps to reproduce:

mkdir -p /tmp/linguist-django
cd /tmp/linguist-django
git clone --depth 1 https://github.com/django/django.git
cd -

./enry /tmp/linguist-django/django/
95.87%	Python
1.85%	JavaScript
1.65%	HTML
0.63%	CSS
0.01%	Shell
0.00%	Smarty
0.00%	Makefile

./enry /tmp/linguist-django/
95.30%	Python
1.83%	JavaScript
1.63%	HTML
0.62%	CSS
0.53%	Roff Manpage
0.04%	Makefile
0.04%	Batchfile
0.01%	Shell
0.00%	Smarty

The difference is in Roff Manpage and Batchfile both under docs/ subdir in Django not being skipped on the second run.

The reason is that current documentation path filtering condition logic is not triggered, as the relative path in second case has prefix and does not match the regexp.

@bzz bzz added the bug label Apr 16, 2019
@bzz bzz added this to the v2.0.0 milestone Apr 16, 2019
@bzz bzz self-assigned this Apr 16, 2019
@bzz
Copy link
Contributor Author

bzz commented Apr 16, 2019

Need to decide if that is expected from the user perspective.

For now, I tend to think that this is a bug.

@bzz bzz removed their assignment Apr 16, 2019
@bzz bzz removed this from the v2.0.0 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant