Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #192

Open
carlosms opened this issue Aug 6, 2019 · 6 comments
Open

Add unit tests #192

carlosms opened this issue Aug 6, 2019 · 6 comments
Assignees

Comments

@carlosms
Copy link
Contributor

carlosms commented Aug 6, 2019

We should have as many unit tests as makes sense.
When possible, all features that can be tested with unit tests instead of integration tests will save time.

@smacker smacker self-assigned this Aug 7, 2019
This was referenced Aug 7, 2019
This was referenced Aug 19, 2019
@smacker
Copy link
Contributor

smacker commented Oct 1, 2019

I added tests to internal packages. My idea was to also add some tests for cmd package with mocked docker dependency but as I'm not working on it right now, I'm returning the issue into todo.

@smacker smacker removed their assignment Oct 1, 2019
@se7entyse7en
Copy link
Contributor

se7entyse7en commented Oct 1, 2019

@kyrcha will start looking into this so that we can also familiarize with the project. @kyrcha do you mind self-assigning yourself this card then?

@kyrcha
Copy link

kyrcha commented Oct 1, 2019

@se7entyse7en Sure. Could you add the QA team to the repo and also to the metadata because I cannot do the assignment myself?
Related issue: src-d/metadata-retrieval#13

@se7entyse7en
Copy link
Contributor

@se7entyse7en Sure. Could you add the QA team to the repo and also to the metadata because I cannot do the assignment myself?

\cc @smola what's the policy here? maybe QA should be part of all repos by default?

@se7entyse7en
Copy link
Contributor

@kyrcha I'll manually add you for now 👍

@smola
Copy link

smola commented Oct 2, 2019

@se7entyse7en We have pending some automation of GitHub permissions by infra. Other than that, please add QA team with Write permission to any repository on demand. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants