Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race in TestP2pNetwork_MessageValidation #1732

Open
AKorpusenko opened this issue Sep 11, 2024 · 2 comments
Open

Data race in TestP2pNetwork_MessageValidation #1732

AKorpusenko opened this issue Sep 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@AKorpusenko
Copy link
Contributor

AKorpusenko commented Sep 11, 2024 •
edited
Loading

@AKorpusenko AKorpusenko added the bug Something isn't working label Sep 11, 2024
@nkryuchkov
Copy link
Contributor

https://github.com/ssvlabs/ssv/actions/runs/11111346936/job/30871052939

@nkryuchkov
Copy link
Contributor

nkryuchkov commented Oct 22, 2024 •
edited
Loading

https://github.com/ssvlabs/ssv/actions/runs/11466922731/job/31916750156?pr=1813

WARNING: DATA RACE
Read at 0x00c00053e060 by goroutine 2739:
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).connectionsAtLimit()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:326 +0x9e
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).connectionsAtLimit-fm()
      <autogenerated>:1 +0x1f
  github.com/ssvlabs/ssv/network/peers/connections.(*connGater).InterceptAccept()
      /home/runner/work/ssv/ssv/network/peers/connections/conn_gater.go:85 +0x1d9
  github.com/libp2p/go-libp2p/p2p/net/upgrader.(*listener).handleIncoming()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/listener.go:88 +0xbf7
  github.com/libp2p/go-libp2p/p2p/net/upgrader.(*upgrader).UpgradeListener.gowrap1()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:119 +0x33

Previous write at 0x00c00053e060 by goroutine 1932:
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).setupPeerServices()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:188 +0x1104
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).SetupServices()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:153 +0xc4
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).Setup()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:74 +0x45e
  github.com/ssvlabs/ssv/network/p2p.(*LocalNet).NewTestP2pNetwork()
      /home/runner/work/ssv/ssv/network/p2p/test_utils.go:232 +0x18dd

WARNING: DATA RACE
Read at 0x00c02913f248 by goroutine 2739:
  github.com/ssvlabs/ssv/network/peers.(*peersIndex).AtLimit()
      /home/runner/work/ssv/ssv/network/peers/peers_index.go:100 +0x37
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).connectionsAtLimit()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:329 +0xdd
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).connectionsAtLimit-fm()
      <autogenerated>:1 +0x1f
  github.com/ssvlabs/ssv/network/peers/connections.(*connGater).InterceptAccept()
      /home/runner/work/ssv/ssv/network/peers/connections/conn_gater.go:85 +0x1d9
  github.com/libp2p/go-libp2p/p2p/net/upgrader.(*listener).handleIncoming()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/listener.go:88 +0xbf7
  github.com/libp2p/go-libp2p/p2p/net/upgrader.(*upgrader).UpgradeListener.gowrap1()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:119 +0x33

Previous write at 0x00c02913f248 by goroutine 1932:
  github.com/ssvlabs/ssv/network/peers.NewPeersIndex()
      /home/runner/work/ssv/ssv/network/peers/peers_index.go:52 +0x1014
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).setupPeerServices()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:188 +0x868
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).SetupServices()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:153 +0xc4
  github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).Setup()
      /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:74 +0x45e

WARNING: DATA RACE
Read at 0x00c02913f1f8 by goroutine 2739:
github.com/ssvlabs/ssv/network/peers.(*peersIndex).AtLimit()
    /home/runner/work/ssv/ssv/network/peers/peers_index.go:101 +0x64
github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).connectionsAtLimit()
    /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:329 +0xdd
github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).connectionsAtLimit-fm()
    <autogenerated>:1 +0x1f
github.com/ssvlabs/ssv/network/peers/connections.(*connGater).InterceptAccept()
    /home/runner/work/ssv/ssv/network/peers/connections/conn_gater.go:85 +0x1d9
github.com/libp2p/go-libp2p/p2p/net/upgrader.(*listener).handleIncoming()
    /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/listener.go:88 +0xbf7
github.com/libp2p/go-libp2p/p2p/net/upgrader.(*upgrader).UpgradeListener.gowrap1()
    /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:119 +0x33

Previous write at 0x00c02913f1f8 by goroutine 1932:
github.com/ssvlabs/ssv/network/peers.NewPeersIndex()
    /home/runner/work/ssv/ssv/network/peers/peers_index.go:46 +0xe08
github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).setupPeerServices()
    /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:188 +0x868
github.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).SetupServices()
    /home/runner/work/ssv/ssv/network/p2p/p2p_setup.go:153 +0xc4

@nkryuchkov nkryuchkov mentioned this issue Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AKorpusenko @nkryuchkov