fix(CommitteeObserver): post consensus mem leak #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
approved these changes
Nov 19, 2024
nkryuchkov
changed the title
CommitteeObserver - post conesnsus mem leak
iurii-ssv
approved these changes
Nov 21, 2024
nkryuchkov
reviewed
Nov 21, 2024
moshe-blox
approved these changes
Nov 21, 2024
y0sher
force-pushed
the
fix/ncv-postcons-memleak
branch
from
2e17fa6 to
e4ed505
Compare
nkryuchkov
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1857
Remove 12 old slots after each message processing.
NOTE: maybe we need tracking of latest actual slot in order to ignore old messages? what if we already removed but got new msg?