-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
by a semantic version constraint matched against a Composer dependency not working #52
Comments
thanks for reporting. it works in my tests as expected. could you create a small reproducing repo? It might be something specific to typo3 |
Thanks for your fast response, and sure: https://github.com/DanielSiepmann/phpstan-todo-by-issue-52 I broke our setup down to the minimum. It seems the issue is caused by typo3/minimal dependency. So not really related to TYPO3 I guess, but to metapackages in general? I'm not too deep into this topic. |
thanks for the repro. as soon as maybe you can reduce it further from this point? |
I could further reduce to only include typo3/cms-core and typo3/cms-backend. |
thank you. I think it will be fixed with #54 - I need a proper automated test for staabm/phpstan-todo-by to land it though. could you work on that? |
Thank you very much for such a fast fix. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The "by a semantic version constraint matched against a Composer dependency" approach does not work. We receive the following output:
I tried to debug via xdebug and it looks like the
!InstalledVersions::isInstalled
call is heading to phpstan phar version and its own packages composer dependencies instead of the actual project dependencies.The text was updated successfully, but these errors were encountered: