Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support logging to file #795

Closed
nightkr opened this issue May 23, 2024 · 1 comment · Fixed by #814
Closed

Support logging to file #795

nightkr opened this issue May 23, 2024 · 1 comment · Fixed by #814
Assignees
@nightkr
Labels
type/feature-new

Comments

@nightkr
Copy link
Member

nightkr commented May 23, 2024

This is mostly for not-operators that still depend on op-rs for consistency with the rest of the platform (like the OPA bundle builder).

It should support rotation via https://docs.rs/tracing-appender/latest/tracing_appender/.
@nightkr nightkr mentioned this issue May 23, 2024
Merged
@nightkr nightkr self-assigned this Jun 20, 2024
@nightkr nightkr moved this to Development: In Progress in Stackable Engineering Jun 20, 2024
nightkr added a commit that referenced this issue Jun 20, 2024
@nightkr
Add environment variable for logging to file
764af40 
Fixes #795
@nightkr nightkr mentioned this issue Jun 20, 2024
Merged
@NickLarsenNZ
Copy link
Member

Just a note, we'll want to pull this functionality over to stackable-telemetry.
Nothing to do just now, but wanted to mention it.

@nightkr nightkr moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jun 27, 2024
@lfrancke lfrancke mentioned this issue Jul 22, 2024
Closed
@lfrancke lfrancke moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 25, 2024
@nightkr nightkr mentioned this issue Jul 29, 2024
Open
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
@nightkr @siegfriedweber
Add option to log to file (#814)
3a0e3bc 
* Add environment variable for logging to file

Fixes #795

* Actually print log directory

* Reconfigure Vector to read OPA bundle builder logs without multilog

* Log to file as JSON

* Changelog

* Move tracing-appender dependency to workspace

* Reenable hourly rotation

* Move changelog entry to unreleased

* Generalize bundle builder Vector rule

* More changelog fixup

* Update crates/stackable-operator/src/logging/mod.rs

Co-authored-by: Siegfried Weber <[email protected]>

---------

Co-authored-by: Siegfried Weber <[email protected]>
@nightkr nightkr moved this from Development: In Review to Development: Done in Stackable Engineering Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightkr nightkr

Labels
type/feature-new
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to log to file stackabletech/operator-rs
2 participants
@nightkr @NickLarsenNZ