Split large generated files

[robinkrahl]

The generated files in fitparser/src/profile are so big that GitHub refuses to display them to unauthenticated users and that it is hard to read diffs from SDK updates. Have you considered splitting them into sub-modules per message or field type?

[stadelmanma]

I hadn’t really considered it. I’ve only ever given those diffs a quick scroll through on the command line and moved on unless something looked fishy. I don’t think I’d be opposed to splitting them up as long as there’s not any undesirable side effects like greatly increasing build times.

I can’t imagine runtime performance would change at all, nor would the size of the code on disk appreciably increase.

[Lingepumpe]

What files are you having trouble viewing?

I had a look at the last SDK update diffs, in a private tab (so without authentication), and that works: https://github.com/stadelmanma/fitparse-rs/pull/42/files
And if I view an individual huge file like https://github.com/stadelmanma/fitparse-rs/blob/master/fitparser/src/profile/decode.rs- that also works.

If there are some files that you cannot view without authenticating, there is always the options of:

• Cloning the repo and viewing it on your own computer
• Downloading the repo and viewing it on your own computer
• logging into github