Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from size aesthetic to linewidth as size is deprecated. #335

Open
sims1253 opened this issue Dec 16, 2024 · 1 comment
Open

Move from size aesthetic to linewidth as size is deprecated. #335

sims1253 opened this issue Dec 16, 2024 · 1 comment

Comments

@sims1253
Copy link
Contributor

Since ggplot2 3.4.0 the size aesthetic for lines is deprecated and linewidth should be used instead. As size is absolute and linewidth is relative, the 1 to 1 plot comparison tests will most likely fail as it'll be hard to find the exact linewidth equivalent of the current size values.

@jgabry
Copy link
Member

jgabry commented Dec 17, 2024

Yeah there are probably still some cases of this that need to be changed. I think a bunch of cases have already been updated to linewidth (at least on GitHub, maybe not in the CRAN version yet), but not all. If we can get the sizes close enough that the plots don't change substantially that's fine. It will break the visual tests, but that's probably unavoidable, like you say, and we can reset them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants