Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL with GloVe dataset not working #174

Open
Nayef211 opened this issue Jul 8, 2020 · 6 comments
Open

URL with GloVe dataset not working #174

Nayef211 opened this issue Jul 8, 2020 · 6 comments

Comments

@Nayef211
Copy link

Nayef211 commented Jul 8, 2020

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Jul 8, 2020 via email

@zhangguanheng66
Copy link

We have disabled our tests again due to the URL issue.
pytorch/text#888

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Jul 17, 2020 via email

@Nayef211
Copy link
Author

Disabled tests again due to URL breakage pytorch/text#920.

To answer your question @AngledLuffa, we are using mock zip files for our tests, however, the filename is found by getting the headers from a HTTP GET call. You can refer to this code snippet for more info.

@Nayef211 Nayef211 reopened this Aug 12, 2020
@AngledLuffa
Copy link
Contributor

AngledLuffa commented Aug 12, 2020 via email

@zhangguanheng66
Copy link

Can I recommend mocking that as well, then? Because our hardware occasionally has problems, and while we obviously want to fix it as quickly as possible, we also don't want to be responsible for your unit tests not working.

Yeap. That's what we are planning to do. But we probably won't moch the entire datasets because we don't want to host the datasets for legal issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants