-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL with GloVe dataset not working #174
Comments
Our cluster is currently down for maintenance. It should be back within a
day.
|
We have disabled our tests again due to the URL issue. |
I'm a little confused by that comment, because aren't those tests
downloading mock zip files instead of the original zip files on
nlp.stanford.edu?
Regardless, the nlp.stanford.edu url is working again.
|
Disabled tests again due to URL breakage pytorch/text#920. To answer your question @AngledLuffa, we are using mock zip files for our tests, however, the filename is found by getting the headers from a HTTP GET call. You can refer to this code snippet for more info. |
Can I recommend mocking that as well, then? Because our hardware
occasionally has problems, and while we obviously want to fix it as quickly
as possible, we also don't want to be responsible for your unit tests not
working.
|
Yeap. That's what we are planning to do. But we probably won't moch the entire datasets because we don't want to host the datasets for legal issue. |
The text was updated successfully, but these errors were encountered: