Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexiDag] BlockStorage::delete_block don't processe dag_sync_block_storage #4057

Open
nkysg opened this issue May 13, 2024 · 0 comments
Open
Assignees
Labels
enhancement Enhancement

Comments

@nkysg
Copy link
Collaborator

nkysg commented May 13, 2024

#[derive(Clone)]
pub struct BlockStorage {
    block_store: BlockInnerStorage,
    pub(crate) header_store: BlockHeaderStorage,
    body_store: BlockBodyStorage,
    block_txns_store: BlockTransactionsStorage,
    block_txn_infos_store: BlockTransactionInfosStorage,
    failed_block_storage: FailedBlockStorage,
    dag_sync_block_storage: DagSyncBlockStorage,
}

    pub fn delete_block(&self, block_id: HashValue) -> Result<()> {
        self.header_store.remove(block_id)?;
        self.body_store.remove(block_id)?;
        self.block_store.remove(block_id)?;
        self.block_txns_store.remove(block_id)?;
        self.block_txn_infos_store.remove(block_id)
    }

if we need self.dag_sync_block_storage.remove(block_id)

@nkysg nkysg added the enhancement Enhancement label May 13, 2024
@jackzhhuang jackzhhuang self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants