-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snip 9 - Outside Execution #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly some grammar stuff and couple of questions from my side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Note: I did a restructuring and rebase to PR #1111 so Konstantin can also be tracked by GitHub as a contributor.
[call1], | ||
OutsideExecutionVersion.V2 | ||
); | ||
expect(message).toEqual({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change anything now but just wanted to mention that in the future when dealing with large objects as the expected result of tests using snapshots might be simpler.
* feat: draft SNIP-9 implementation (#1111) * feat: finalize SNIP-9 outside execution implementation (#1202) --------- Co-authored-by: Konstantin Fastov <[email protected]> Co-authored-by: Philippe ROSTAN <[email protected]>
# [6.13.0](v6.12.1...v6.13.0) (2024-08-27) ### Bug Fixes * repair enum type lookup for typed data hashing ([36f8c3c](36f8c3c)) * sync cryptographic dependencies ([da20310](da20310)) ### Features * implement SNIP-9 outside execution functionality ([#1208](#1208)) ([e3c80c5](e3c80c5)), closes [#1111](#1111) [#1202](#1202) * improve message verification utilities ([#1198](#1198)) ([bdad9a5](bdad9a5))
Motivation and Resolution
Solves issue #948 and replace stuck PR #1111 .
Implantation of the concept of execution of a transaction signed by an other account, standardized in SNIP-9.
Usage related changes
Most usages are explained in a dedicated guide, and detailed usage is explained in JSDoc.
2 main functions :
Creation of an outside transaction object with
Account.getOutsideTransaction()
call1
can be an array ofCall
.Execution from an other account with
Account.executeFromOutside()
outsideTransaction1
can be an array ofOutsideTransaction
Development related changes
Checklist: