Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo u96 implementation #1247

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Cairo u96 implementation #1247

merged 3 commits into from
Oct 24, 2024

Conversation

PhilippeR26
Copy link
Collaborator

Motivation and Resolution

Cairo has introduced a new type : u96
In an abi, it's identified as a non trivial description : core::internal::bounded_int::BoundedInt::<0, 79228162514264337593543950335> No comments 🧐
It's represented as a number in the calldata.

Usage related changes

u96 is now handled and can be manipulated as a BigNuberish.

Development related changes

u96 is handled as a litteral.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WP LGTM!

@ivpavici ivpavici merged commit 06f0a80 into starknet-io:develop Oct 24, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
# [6.17.0](v6.16.0...v6.17.0) (2024-10-24)

### Features

* Cairo u96 implementation ([#1247](#1247)) ([06f0a80](06f0a80))
Copy link

🎉 This issue has been resolved in version 6.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants